Skip to content

Commit 18b7113

Browse files
rpoiseltargos
authored andcommitted
test: make exported method static
The exported method can be static as it will never be called directly. PR-URL: #29102 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent a17d398 commit 18b7113

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/addons/hello-world/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include <node.h>
22
#include <v8.h>
33

4-
void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
4+
static void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
55
v8::Isolate* isolate = args.GetIsolate();
66
args.GetReturnValue().Set(v8::String::NewFromUtf8(
77
isolate, "world", v8::NewStringType::kNormal).ToLocalChecked());

0 commit comments

Comments
 (0)