Skip to content

Commit 1998bc8

Browse files
ruyadornojuanarbol
authored andcommitted
doc: fix release guide example consistency
This changeset fixes two consistency issues in this single example that guides releasers on how to push the tag to the remote repo. The first issue is that the remote git reference is consistently referred as `upstream` elsewhere in the guide. The second issue being that the version example used in the rest of the guide should be a fictional `v1.2.3` as stated in the "How to create a release" guide notes: > * Examples will use the fictional release version `1.2.3`. PR-URL: #44385 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 7b69172 commit 1998bc8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

doc/contributing/releases.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ haven't pushed your tag first, then build promotion won't work properly.
744744
Push the tag using the following command:
745745

746746
```console
747-
$ git push <remote> <vx.y.z>
747+
$ git push upstream v1.2.3
748748
```
749749

750750
_Note_: Please do not push the tag unless you are ready to complete the

0 commit comments

Comments
 (0)