Skip to content

Commit 1a7e872

Browse files
evanlucasMylesBorins
authored andcommitted
build,tools: do not force codesign prefix
Allow passing the prefix in via the PKGDIR env var. This will allow us to use this same script to codesign the binary tarball. PR-URL: #14179 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 1d5ba9c commit 1a7e872

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,8 @@ $(PKG): release-only
565565
--release-urlbase=$(RELEASE_URLBASE) \
566566
$(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
567567
$(MAKE) install V=$(V) DESTDIR=$(PKGDIR)
568-
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh
568+
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)/usr/local" bash \
569+
tools/osx-codesign.sh
569570
cat tools/osx-pkg.pmdoc/index.xml.tmpl \
570571
| sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \
571572
| sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \

tools/osx-codesign.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ if [ "X$SIGN" == "X" ]; then
88
exit 0
99
fi
1010

11-
codesign -s "$SIGN" "$PKGDIR"/usr/local/bin/node
11+
codesign -s "$SIGN" "$PKGDIR"/bin/node

0 commit comments

Comments
 (0)