Skip to content

Commit 1ab998f

Browse files
Qantas94Heavyevanlucas
authored andcommitted
test: fix allocUnsafe uninitialized buffer check
Fixes parallel/test-buffer-bindingobj-no-zerofill to properly check that buffers created with `Buffer.allocUnsafe()` are not zero-filled. The test introduced in #11706 passes even if the buffer has been zero-filled and fails if none of the buffer values are zero. Refs: #11706 PR-URL: #12290 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 71b39ae commit 1ab998f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-buffer-bindingobj-no-zerofill.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const monkeyPatchedBuffer = require('../../lib/buffer');
4444
// possible that a segment of memory is already zeroed out, so try again and
4545
// again until we succeed or we time out.
4646
let uninitialized = buffer.Buffer.allocUnsafe(1024);
47-
while (uninitialized.some((val) => val !== 0))
47+
while (uninitialized.every((val) => val === 0))
4848
uninitialized = buffer.Buffer.allocUnsafe(1024);
4949

5050
// On monkeypatched buffer, zeroFill property is undefined. allocUnsafe() should

0 commit comments

Comments
 (0)