Skip to content

Commit 1acd4d2

Browse files
cjihrigjasnell
authored andcommitted
src: assert that uv_async_init() succeeds
This commit fixes two coverity warnings for unchecked return values. Refs: #13050 PR-URL: #13116 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent f36c970 commit 1acd4d2

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/cares_wrap.cc

+6-2
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,9 @@ class QueryWrap : public AsyncWrap {
534534
data->len = answer_len;
535535

536536
uv_async_t* async_handle = &data->async_handle;
537-
uv_async_init(wrap->env()->event_loop(), async_handle, CaresAsyncCb);
537+
CHECK_EQ(0, uv_async_init(wrap->env()->event_loop(),
538+
async_handle,
539+
CaresAsyncCb));
538540

539541
wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED);
540542
async_handle->data = data;
@@ -558,7 +560,9 @@ class QueryWrap : public AsyncWrap {
558560
data->is_host = true;
559561

560562
uv_async_t* async_handle = &data->async_handle;
561-
uv_async_init(wrap->env()->event_loop(), async_handle, CaresAsyncCb);
563+
CHECK_EQ(0, uv_async_init(wrap->env()->event_loop(),
564+
async_handle,
565+
CaresAsyncCb));
562566

563567
wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED);
564568
async_handle->data = data;

0 commit comments

Comments
 (0)