Skip to content

Commit 1af7f24

Browse files
Anemydanielleadams
authored andcommitted
util: remove unicode support todo for perf implications
PR-URL: #43762 Refs: #43721 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent bf3991b commit 1af7f24

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/internal/util/inspect.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1596,8 +1596,9 @@ function formatPrimitive(fn, value, ctx) {
15961596
trailer = `... ${remaining} more character${remaining > 1 ? 's' : ''}`;
15971597
}
15981598
if (ctx.compact !== true &&
1599-
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
1600-
// function.
1599+
// We do not support handling unicode characters width with
1600+
// the readline getStringWidth function as there are
1601+
// performance implications.
16011602
value.length > kMinLineLength &&
16021603
value.length > ctx.breakLength - ctx.indentationLvl - 4) {
16031604
return value

0 commit comments

Comments
 (0)