crypto: add ocsp_request ClientHelloParser::Reset

danbev · MylesBorins · commit 1b8d3ec5e77a · 2018-01-09T04:32:41.000-05:00
I noticed that ocsp_request is not being reset in ClientHelloParser::Reset. I've not been able to figure out the the reason for this and wanted to bring this up just in case this was overlooked and should be reset. PR-URL: #17753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto_clienthello-inl.h b/src/node_crypto_clienthello-inl.h
@@ -55,6 +55,7 @@ inline void ClientHelloParser::Reset() {
   tls_ticket_ = nullptr;
   servername_size_ = 0;
   servername_ = nullptr;
+  ocsp_request_ = 0;
 }
 
 inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ inline void ClientHelloParser::Reset() {`
`55`	`55`	`tls_ticket_ = nullptr;`
`56`	`56`	`servername_size_ = 0;`
`57`	`57`	`servername_ = nullptr;`
	`58`	`+ ocsp_request_ = 0;`
`58`	`59`	`}`
`59`	`60`
`60`	`61`	`inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,`