Skip to content

Commit 1ba6d16

Browse files
bnoordhuisrvagg
authored andcommitted
build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: #6724 PR-URL: #6737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 8a4a26b commit 1ba6d16

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Diff for: common.gypi

+5-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,11 @@
181181
}],
182182
[ 'OS in "linux freebsd openbsd solaris android"', {
183183
'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
184-
'cflags_cc': [ '-fno-rtti', '-fno-exceptions' ],
184+
'cflags_cc': [
185+
'-fno-delete-null-pointer-checks',
186+
'-fno-exceptions',
187+
'-fno-rtti',
188+
],
185189
'ldflags': [ '-rdynamic' ],
186190
'target_conditions': [
187191
['_type=="static_library"', {

0 commit comments

Comments
 (0)