Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 1c2d77d

Browse files
committedFeb 18, 2020
2020-02-18, Version 12.16.1 'Erbium' (LTS)
Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: #31781
1 parent 58de9b4 commit 1c2d77d

File tree

3 files changed

+67
-2
lines changed

3 files changed

+67
-2
lines changed
 

‎CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ release.
4141
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
4242
</td>
4343
<td valign="top">
44-
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.16.0">12.16.0</a></b><br/>
44+
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.16.1">12.16.1</a></b><br/>
45+
<a href="doc/changelogs/CHANGELOG_V12.md#12.16.0">12.16.0</a><br/>
4546
<a href="doc/changelogs/CHANGELOG_V12.md#12.15.0">12.15.0</a><br/>
4647
<a href="doc/changelogs/CHANGELOG_V12.md#12.14.1">12.14.1</a><br/>
4748
<a href="doc/changelogs/CHANGELOG_V12.md#12.14.0">12.14.0</a><br/>

‎doc/changelogs/CHANGELOG_V12.md

+64
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
</tr>
1111
<tr>
1212
<td valign="top">
13+
<a href="#12.16.1">12.16.1</a><br/>
1314
<a href="#12.16.0">12.16.0</a><br/>
1415
<a href="#12.15.0">12.15.0</a><br/>
1516
<a href="#12.14.1">12.14.1</a><br/>
@@ -54,6 +55,69 @@
5455
* [io.js](CHANGELOG_IOJS.md)
5556
* [Archive](CHANGELOG_ARCHIVE.md)
5657

58+
<a id="12.16.1"></a>
59+
## 2020-02-18, Version 12.16.1 'Erbium' (LTS), @MylesBorins
60+
61+
### Notable changes
62+
63+
Node.js 12.16.0 included 6 regressions that are being fixed in this release
64+
65+
**Accidental Unflagging of Self Resolving Modules**:
66+
67+
12.16.0 included a large update to the ESM implementation. One of the new features,
68+
Self Referential Modules, was accidentally released without requiring the `--experimental-modules`
69+
flag. This release is being made to appropriately flag the feature.
70+
71+
**Process Cleanup Changed Introduced WASM-Related Assertion**:
72+
73+
A change during Node.js process cleanup led to a crash in combination with
74+
specific usage of WASM. This has been fixed by partially reverted said change.
75+
A regression test and a full fix are being worked on and will likely be included
76+
in future 12.x and 13.x releases.
77+
78+
**Use Largepages Runtime Option Introduced Linking Failure**:
79+
80+
A Semver-Minor change to introduce `--use-largepages` as a runtime option
81+
introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out
82+
in a Current release. The feature has been reverted, but will be able to reland with a fix in a future
83+
Semver-Minor release.
84+
85+
**Async Hooks was Causing an Exception When Handling Errors**:
86+
87+
Changes in async hooks internals introduced a case where an internal api call could be called with undefined
88+
causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed
89+
and the change could re land in a future Semver-Patch release if the regression is reliably fixed.
90+
91+
**New Enumerable Read-Only Property on EventEmitter breaks @types/extend**
92+
93+
A new property for enumerating events was added to the EventEmitter class. This
94+
broke existing code that was using the `@types/extend` module for extending classses
95+
as `@types/extend` was attemping to write over the existing field which the new
96+
change made read-only. As this is the first property on EventEmitter that is
97+
read-only this feature could be considered Semver-Major. The new feature has been
98+
reverted but could re land in a future Semver-Minor release if a non breaking way
99+
of applying it is found.
100+
101+
**Exceptions in the HTTP parser were not emitting an uncaughtException**
102+
103+
A refactoring to Node.js interanls resulted in a bug where errors in the HTTP
104+
parser were not being emitted by `process.on('uncaughtException')`. The fix
105+
to this bug has been included in this release.
106+
107+
### Commits
108+
109+
* [[`51fdd759b9`](https://github.com/nodejs/node/commit/51fdd759b9)] - **async_hooks**: ensure event after been emitted on runInAsyncScope (legendecas) [#31784](https://github.com/nodejs/node/pull/31784)
110+
* [[`7a1b0ac06f`](https://github.com/nodejs/node/commit/7a1b0ac06f)] - ***Revert*** "**build**: re-introduce --use-largepages as no-op" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782)
111+
* [[`a53eeca2a9`](https://github.com/nodejs/node/commit/a53eeca2a9)] - ***Revert*** "**build**: switch realpath to pwd" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782)
112+
* [[`6d432994e6`](https://github.com/nodejs/node/commit/6d432994e6)] - ***Revert*** "**build**: warn upon --use-largepages config option" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782)
113+
* [[`a5bc00af12`](https://github.com/nodejs/node/commit/a5bc00af12)] - ***Revert*** "**events**: allow monitoring error events" (Myles Borins)
114+
* [[`f0b2d875d9`](https://github.com/nodejs/node/commit/f0b2d875d9)] - **module**: 12.x self resolve flag as experimental modules (Guy Bedford) [#31757](https://github.com/nodejs/node/pull/31757)
115+
* [[`42b68a4e24`](https://github.com/nodejs/node/commit/42b68a4e24)] - **src**: inform callback scopes about exceptions in HTTP parser (Anna Henningsen) [#31801](https://github.com/nodejs/node/pull/31801)
116+
* [[`065a32f064`](https://github.com/nodejs/node/commit/065a32f064)] - ***Revert*** "**src**: make --use-largepages a runtime option" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782)
117+
* [[`3d5beebc62`](https://github.com/nodejs/node/commit/3d5beebc62)] - ***Revert*** "**src**: make large\_pages node.cc include conditional" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782)
118+
* [[`43d02e20e0`](https://github.com/nodejs/node/commit/43d02e20e0)] - **src**: keep main-thread Isolate attached to platform during Dispose (Anna Henningsen) [#31795](https://github.com/nodejs/node/pull/31795)
119+
* [[`7a5954ef26`](https://github.com/nodejs/node/commit/7a5954ef26)] - **src**: fix -Winconsistent-missing-override warning (Colin Ihrig) [#30549](https://github.com/nodejs/node/pull/30549)
120+
57121
<a id="12.16.0"></a>
58122
## 2020-02-11, Version 12.16.0 'Erbium' (LTS), @targos
59123

‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#define NODE_VERSION_IS_LTS 0
3030
#define NODE_VERSION_LTS_CODENAME ""
3131

32-
#define NODE_VERSION_IS_RELEASE 0
32+
#define NODE_VERSION_IS_RELEASE 1
3333

3434
#ifndef NODE_STRINGIFY
3535
#define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)

0 commit comments

Comments
 (0)
Please sign in to comment.