Skip to content

Commit 1c494b0

Browse files
committed
deps: silence irrelevant V8 warnings
PR-URL: #25852 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent ff5d632 commit 1c494b0

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

deps/v8/gypfiles/toolchain.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -1393,7 +1393,7 @@
13931393
], # conditions
13941394
}, # Release
13951395
}, # configurations
1396-
'cflags': [ '-Wno-type-limits', ],
1396+
'cflags!': [ '-Wall', '-Wextra' ],
13971397
'msvs_disabled_warnings': [
13981398
4245, # Conversion with signed/unsigned mismatch.
13991399
4267, # Conversion with possible loss of data.

deps/v8/include/v8.h

+2-3
Original file line numberDiff line numberDiff line change
@@ -4337,14 +4337,13 @@ class V8_EXPORT CompiledWasmModule {
43374337
class V8_EXPORT WasmModuleObject : public Object {
43384338
public:
43394339
// TODO(clemensh): Remove after 7.3 branch.
4340-
V8_DEPRECATED("Use OwnedBuffer", typedef)
4341-
std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
4340+
typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
43424341

43434342
/**
43444343
* A unowned reference to a byte buffer.
43454344
* TODO(clemensh): Remove after 7.3 branch.
43464345
*/
4347-
V8_DEPRECATED("Use MemorySpan<const uint8_t>", struct) BufferReference {
4346+
struct BufferReference {
43484347
const uint8_t* start;
43494348
size_t size;
43504349
BufferReference(const uint8_t* start, size_t size)

0 commit comments

Comments
 (0)