Skip to content

Commit 1e4a2bc

Browse files
Trottjasnell
authored andcommitted
crypto: remove check for condition that is always true
The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`. PR-URL: #38072 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 78b6f38 commit 1e4a2bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/internal/crypto/sig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ function signOneShot(algorithm, data, key, callback) {
177177
let keyData;
178178
if (isKeyObject(key) || isCryptoKey(key)) {
179179
({ data: keyData } = preparePrivateKey(key));
180-
} else if (key != null && (isKeyObject(key.key) || isCryptoKey(key.key))) {
180+
} else if (isKeyObject(key.key) || isCryptoKey(key.key)) {
181181
({ data: keyData } = preparePrivateKey(key.key));
182182
} else {
183183
keyData = createPrivateKey(key)[kHandle];

0 commit comments

Comments
 (0)