Skip to content

Commit 1edd47e

Browse files
addaleaxtargos
authored andcommitted
src: disable debug options when inspector is unavailable
This fixes `parallel/test-cli-node-print-help` when Node.js is compiled without the inspector. PR-URL: #22657 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
1 parent cfca851 commit 1edd47e

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/node_options.cc

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ namespace options_parser {
2323
// TODO(addaleax): Make that unnecessary.
2424

2525
DebugOptionsParser::DebugOptionsParser() {
26+
#if HAVE_INSPECTOR
2627
AddOption("--inspect-port",
2728
"set host:port for inspector",
2829
&DebugOptions::host_port,
@@ -52,6 +53,7 @@ DebugOptionsParser::DebugOptionsParser() {
5253
AddOption("--debug-brk", "", &DebugOptions::break_first_line);
5354
Implies("--debug-brk", "--debug");
5455
AddAlias("--debug-brk=", { "--inspect-port", "--debug-brk" });
56+
#endif
5557
}
5658

5759
DebugOptionsParser DebugOptionsParser::instance;

test/parallel/test-cli-bad-options.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ require('../common');
66
const assert = require('assert');
77
const spawn = require('child_process').spawnSync;
88

9-
requiresArgument('--inspect-port');
10-
requiresArgument('--inspect-port=');
11-
requiresArgument('--debug-port');
12-
requiresArgument('--debug-port=');
9+
if (process.config.variables.v8_enable_inspector === 1) {
10+
requiresArgument('--inspect-port');
11+
requiresArgument('--inspect-port=');
12+
requiresArgument('--debug-port');
13+
requiresArgument('--debug-port=');
14+
}
1315
requiresArgument('--eval');
1416

1517
function requiresArgument(option) {

0 commit comments

Comments
 (0)