Skip to content

Commit 1fc6fd6

Browse files
Trottdanielleadams
authored andcommitted
build: fix commit-queue-rebase functionality
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: #41140 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent db26bdb commit 1fc6fd6

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

.github/workflows/commit-queue.yml

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
# Needs the whole git history for ncu to work
2727
# See https://github.com/nodejs/node-core-utils/pull/486
2828
fetch-depth: 0
29-
persist-credentials: false
3029
# A personal token is required because pushing with GITHUB_TOKEN will
3130
# prevent commits from running CI after they land. It needs
3231
# to be set here because `checkout` configures GitHub authentication

0 commit comments

Comments
 (0)