Skip to content

Commit 2116ace

Browse files
ChALkeRBethGriggs
authored andcommitted
doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit 0babd18 (pull request #17406), and the testcase for http2stream.pushStream was changed accordingly, but the documentation change was overlooked. This commit fixes it and aligns the documentation with the testcase. This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format. Refs: #21470 Refs: #17406 Backport-PR-URL: #22850 PR-URL: #21487 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 1cdf93e commit 2116ace

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

doc/api/http2.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -3145,7 +3145,7 @@ added: v8.4.0
31453145
Call [`http2stream.pushStream()`][] with the given headers, and wraps the
31463146
given newly created [`Http2Stream`] on `Http2ServerResponse`.
31473147

3148-
The callback will be called with an error with code `ERR_HTTP2_STREAM_CLOSED`
3148+
The callback will be called with an error with code `ERR_HTTP2_INVALID_STREAM`
31493149
if the stream is closed.
31503150

31513151
## Collecting HTTP/2 Performance Metrics

0 commit comments

Comments
 (0)