Skip to content

Commit 21c1b84

Browse files
vsemozhetbytMylesBorins
authored andcommitted
test: decrease inconsistency in the common.js
1. `process.env['PROCESSOR_ARCHITEW6432']` -> `process.env.PROCESSOR_ARCHITEW6432`. 2. `path.dirname(__filename)` -> `__dirname`. 3. `path.resolve(__dirname)` -> `__dirname`. PR-URL: #7758 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 76b8d81 commit 21c1b84

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/common.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@ var child_process = require('child_process');
88
const stream = require('stream');
99
const util = require('util');
1010

11-
const testRoot = path.resolve(process.env.NODE_TEST_DIR ||
12-
path.dirname(__filename));
11+
const testRoot = process.env.NODE_TEST_DIR ?
12+
path.resolve(process.env.NODE_TEST_DIR) : __dirname;
1313

14-
exports.testDir = path.dirname(__filename);
14+
exports.testDir = __dirname;
1515
exports.fixturesDir = path.join(exports.testDir, 'fixtures');
1616
exports.libDir = path.join(exports.testDir, '../lib');
1717
exports.tmpDirName = 'tmp';
1818
exports.PORT = +process.env.NODE_COMMON_PORT || 12346;
1919
exports.isWindows = process.platform === 'win32';
2020
exports.isWOW64 = exports.isWindows &&
21-
(process.env['PROCESSOR_ARCHITEW6432'] !== undefined);
21+
(process.env.PROCESSOR_ARCHITEW6432 !== undefined);
2222
exports.isAix = process.platform === 'aix';
2323
exports.isLinuxPPCBE = (process.platform === 'linux') &&
2424
(process.arch === 'ppc64') &&

0 commit comments

Comments
 (0)