Skip to content

Commit 21c5d82

Browse files
Salame WilliamMylesBorins
Salame William
authored andcommitted
doc: add references to PR communication articles
Added some references to PR communication articles in Helpful Ressources inside COLLABORATOR_GUIDE.md PR-URL: #17902 Fixes: #16359 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
1 parent e16d01f commit 21c5d82

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

COLLABORATOR_GUIDE.md

+5
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ oppose the PR, it can be landed. Where there is disagreement among TSC members
116116
or objections from one or more Collaborators, `semver-major` pull requests
117117
should be put on the TSC meeting agenda.
118118

119+
#### Helpful resources
120+
121+
* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
122+
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)
123+
119124
### Waiting for Approvals
120125

121126
Before landing pull requests, sufficient time should be left for input

0 commit comments

Comments
 (0)