Skip to content

Commit 21f7703

Browse files
Trotttargos
authored andcommitted
test: move debugger test case to parallel
Move test case that does not require a predetermined port to parallel. PR-URL: #39300 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
1 parent 0ec93a1 commit 21f7703

File tree

2 files changed

+36
-28
lines changed

2 files changed

+36
-28
lines changed

Diff for: test/parallel/test-debugger-unavailable-port.js

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
'use strict';
2+
const common = require('../common');
3+
4+
common.skipIfInspectorDisabled();
5+
6+
const fixtures = require('../common/fixtures');
7+
const startCLI = require('../common/debugger');
8+
9+
const assert = require('assert');
10+
const { createServer } = require('net');
11+
12+
// Launch w/ unavailable port.
13+
(async () => {
14+
const blocker = createServer((socket) => socket.end());
15+
const port = await new Promise((resolve, reject) => {
16+
blocker.on('error', reject);
17+
blocker.listen(0, '127.0.0.1', () => resolve(blocker.address().port));
18+
});
19+
20+
try {
21+
const script = fixtures.path('debugger', 'three-lines.js');
22+
const cli = startCLI([`--port=${port}`, script]);
23+
const code = await cli.quit();
24+
25+
assert.doesNotMatch(
26+
cli.output,
27+
/report this bug/,
28+
'Omits message about reporting this as a bug');
29+
assert.ok(
30+
cli.output.includes(`waiting for 127.0.0.1:${port} to be free`),
31+
'Tells the user that the port wasn\'t available');
32+
assert.strictEqual(code, 1);
33+
} finally {
34+
blocker.close();
35+
}
36+
})().then(common.mustCall());

Diff for: test/sequential/test-debugger-invalid-args.js

-28
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@ const common = require('../common');
33

44
common.skipIfInspectorDisabled();
55

6-
const fixtures = require('../common/fixtures');
76
const startCLI = require('../common/debugger');
87

98
const assert = require('assert');
10-
const { createServer } = require('net');
119

1210
// Launch CLI w/o args.
1311
{
@@ -31,29 +29,3 @@ const { createServer } = require('net');
3129
assert.strictEqual(code, 1);
3230
});
3331
}
34-
35-
// Launch w/ unavailable port.
36-
(async () => {
37-
const blocker = createServer((socket) => socket.end());
38-
const port = await new Promise((resolve, reject) => {
39-
blocker.on('error', reject);
40-
blocker.listen(0, '127.0.0.1', () => resolve(blocker.address().port));
41-
});
42-
43-
try {
44-
const script = fixtures.path('debugger', 'three-lines.js');
45-
const cli = startCLI([`--port=${port}`, script]);
46-
const code = await cli.quit();
47-
48-
assert.doesNotMatch(
49-
cli.output,
50-
/report this bug/,
51-
'Omits message about reporting this as a bug');
52-
assert.ok(
53-
cli.output.includes(`waiting for 127.0.0.1:${port} to be free`),
54-
'Tells the user that the port wasn\'t available');
55-
assert.strictEqual(code, 1);
56-
} finally {
57-
blocker.close();
58-
}
59-
})().then(common.mustCall());

0 commit comments

Comments
 (0)