Skip to content

Commit 2290c31

Browse files
psmarshallMylesBorins
authored andcommitted
deps: partially revert 'increase V8 deprecation levels'
PR-URL: #24195 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 8552bb4 commit 2290c31

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
# Reset this number to 0 on major V8 upgrades.
3535
# Increment by one for each non-official patch applied to deps/v8.
36-
'v8_embedder_string': '-node.36',
36+
'v8_embedder_string': '-node.37',
3737

3838
# Enable disassembler for `--print-code` v8 options
3939
'v8_enable_disassembler': 1,

deps/v8/include/v8.h

+22-22
Original file line numberDiff line numberDiff line change
@@ -1019,9 +1019,9 @@ class V8_EXPORT PrimitiveArray {
10191019
public:
10201020
static Local<PrimitiveArray> New(Isolate* isolate, int length);
10211021
int Length() const;
1022-
V8_DEPRECATED("Use Isolate* version",
1022+
V8_DEPRECATE_SOON("Use Isolate* version",
10231023
void Set(int index, Local<Primitive> item));
1024-
V8_DEPRECATED("Use Isolate* version",
1024+
V8_DEPRECATE_SOON("Use Isolate* version",
10251025
Local<Primitive> Get(int index));
10261026
void Set(Isolate* isolate, int index, Local<Primitive> item);
10271027
Local<Primitive> Get(Isolate* isolate, int index);
@@ -1739,8 +1739,8 @@ class V8_EXPORT StackTrace {
17391739
/**
17401740
* Returns a StackFrame at a particular index.
17411741
*/
1742-
V8_DEPRECATED("Use Isolate version",
1743-
Local<StackFrame> GetFrame(uint32_t index) const);
1742+
V8_DEPRECATE_SOON("Use Isolate version",
1743+
Local<StackFrame> GetFrame(uint32_t index) const);
17441744
Local<StackFrame> GetFrame(Isolate* isolate, uint32_t index) const;
17451745

17461746
/**
@@ -2451,7 +2451,7 @@ class V8_EXPORT Value : public Data {
24512451

24522452
inline V8_DEPRECATED("Use maybe version",
24532453
Local<Boolean> ToBoolean() const);
2454-
inline V8_DEPRECATED("Use maybe version", Local<String> ToString() const);
2454+
inline V8_DEPRECATE_SOON("Use maybe version", Local<String> ToString() const);
24552455
inline V8_DEPRECATED("Use maybe version", Local<Object> ToObject() const);
24562456
inline V8_DEPRECATED("Use maybe version",
24572457
Local<Integer> ToInteger() const);
@@ -2471,7 +2471,7 @@ class V8_EXPORT Value : public Data {
24712471
Local<Context> context) const;
24722472
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
24732473

2474-
V8_DEPRECATED("Use maybe version", bool BooleanValue() const);
2474+
V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
24752475
V8_DEPRECATED("Use maybe version", double NumberValue() const);
24762476
V8_DEPRECATED("Use maybe version", int64_t IntegerValue() const);
24772477
V8_DEPRECATED("Use maybe version", uint32_t Uint32Value() const);
@@ -2584,7 +2584,7 @@ class V8_EXPORT String : public Name {
25842584
* Returns the number of bytes in the UTF-8 encoded
25852585
* representation of this string.
25862586
*/
2587-
V8_DEPRECATED("Use Isolate version instead", int Utf8Length() const);
2587+
V8_DEPRECATE_SOON("Use Isolate version instead", int Utf8Length() const);
25882588

25892589
int Utf8Length(Isolate* isolate) const;
25902590

@@ -2642,23 +2642,23 @@ class V8_EXPORT String : public Name {
26422642
// 16-bit character codes.
26432643
int Write(Isolate* isolate, uint16_t* buffer, int start = 0, int length = -1,
26442644
int options = NO_OPTIONS) const;
2645-
V8_DEPRECATED("Use Isolate* version",
2646-
int Write(uint16_t* buffer, int start = 0, int length = -1,
2647-
int options = NO_OPTIONS) const);
2645+
V8_DEPRECATE_SOON("Use Isolate* version",
2646+
int Write(uint16_t* buffer, int start = 0, int length = -1,
2647+
int options = NO_OPTIONS) const);
26482648
// One byte characters.
26492649
int WriteOneByte(Isolate* isolate, uint8_t* buffer, int start = 0,
26502650
int length = -1, int options = NO_OPTIONS) const;
2651-
V8_DEPRECATED("Use Isolate* version",
2652-
int WriteOneByte(uint8_t* buffer, int start = 0,
2653-
int length = -1, int options = NO_OPTIONS)
2651+
V8_DEPRECATE_SOON("Use Isolate* version",
2652+
int WriteOneByte(uint8_t* buffer, int start = 0,
2653+
int length = -1, int options = NO_OPTIONS)
26542654
const);
26552655
// UTF-8 encoded characters.
26562656
int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
26572657
int* nchars_ref = NULL, int options = NO_OPTIONS) const;
2658-
V8_DEPRECATED("Use Isolate* version",
2659-
int WriteUtf8(char* buffer, int length = -1,
2660-
int* nchars_ref = NULL,
2661-
int options = NO_OPTIONS) const);
2658+
V8_DEPRECATE_SOON("Use Isolate* version",
2659+
int WriteUtf8(char* buffer, int length = -1,
2660+
int* nchars_ref = NULL,
2661+
int options = NO_OPTIONS) const);
26622662

26632663
/**
26642664
* A zero length string.
@@ -2822,9 +2822,9 @@ class V8_EXPORT String : public Name {
28222822
*/
28232823
static Local<String> Concat(Isolate* isolate, Local<String> left,
28242824
Local<String> right);
2825-
static V8_DEPRECATED("Use Isolate* version",
2826-
Local<String> Concat(Local<String> left,
2827-
Local<String> right));
2825+
static V8_DEPRECATE_SOON("Use Isolate* version",
2826+
Local<String> Concat(Local<String> left,
2827+
Local<String> right));
28282828

28292829
/**
28302830
* Creates a new external string using the data defined in the given
@@ -5049,8 +5049,8 @@ class V8_EXPORT BooleanObject : public Object {
50495049
class V8_EXPORT StringObject : public Object {
50505050
public:
50515051
static Local<Value> New(Isolate* isolate, Local<String> value);
5052-
V8_DEPRECATED("Use Isolate* version",
5053-
static Local<Value> New(Local<String> value));
5052+
V8_DEPRECATE_SOON("Use Isolate* version",
5053+
static Local<Value> New(Local<String> value));
50545054

50555055
Local<String> ValueOf() const;
50565056

0 commit comments

Comments
 (0)