Skip to content

Commit 22ccf2b

Browse files
addaleaxBethGriggs
authored andcommitted
tools: decrease timeout in test.py
This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: #32868 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
1 parent ca7e0a2 commit 22ccf2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def Run(self, tasks):
142142
# Wait for the remaining threads
143143
for thread in threads:
144144
# Use a timeout so that signals (ctrl-c) will be processed.
145-
thread.join(timeout=10000000)
145+
thread.join(timeout=1000000)
146146
except (KeyboardInterrupt, SystemExit):
147147
self.shutdown_event.set()
148148
except Exception:

0 commit comments

Comments
 (0)