Skip to content

Commit 22dcd3e

Browse files
committed
deps: silence irrelevant V8 warnings
PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 1aea6a7 commit 22dcd3e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.5',
39+
'v8_embedder_string': '-node.6',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8.h

+2-3
Original file line numberDiff line numberDiff line change
@@ -1667,7 +1667,7 @@ class V8_EXPORT Module : public Data {
16671667
*/
16681668
int GetIdentityHash() const;
16691669

1670-
using ResolveCallback V8_DEPRECATED("Use ResolveModuleCallback") =
1670+
using ResolveCallback =
16711671
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
16721672
Local<Module> referrer);
16731673
using ResolveModuleCallback = MaybeLocal<Module> (*)(
@@ -7335,8 +7335,7 @@ using CallCompletedCallback = void (*)(Isolate*);
73357335
* fails (e.g. due to stack overflow), the embedder must propagate
73367336
* that exception by returning an empty MaybeLocal.
73377337
*/
7338-
using HostImportModuleDynamicallyCallback V8_DEPRECATED(
7339-
"Use HostImportModuleDynamicallyWithImportAssertionsCallback instead") =
7338+
using HostImportModuleDynamicallyCallback =
73407339
MaybeLocal<Promise> (*)(Local<Context> context,
73417340
Local<ScriptOrModule> referrer,
73427341
Local<String> specifier);

0 commit comments

Comments
 (0)