Skip to content

Commit 2334e32

Browse files
committed
fixup! build: notify via slack when review-wanted
1 parent fc44c62 commit 2334e32

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.github/workflows/notify-on-review-wanted.yml

+12-9
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,30 @@ permissions:
1111
jobs:
1212
notifyOnReviewWanted:
1313
name: Notify on Review Wanted
14-
if: github.repository == 'nodejs/node'
14+
if: github.repository == 'nodejs/node' && github.event.label == 'review wanted'
1515
runs-on: ubuntu-latest
1616
steps:
1717
- name: Determine PR or Issue
18-
id: check_pr_or_issue
18+
id: define-message
1919
run: |
2020
if [[ -n "${{ github.event.pull_request.number }}" ]]; then
21-
echo "::set-output name=type::pull_request"
22-
echo "::set-output name=number::${{ github.event.pull_request.number }}"
21+
number="${{ github.event.pull_request.number }}"
22+
link="https://github.com/${{ github.repository }}/pull/$number"
23+
echo "message=The PR (#$number) requires review from Node.js maintainers. See: $link" >> "$GITHUB_OUTPUT"
24+
echo "title=${{ github.actor }} asks for attention on pull request #$number" >> "$GITHUB_OUTPUT"
2325
else
24-
echo "::set-output name=type::issue"
25-
echo "::set-output name=number::${{ github.event.issue.number }}"
26+
number="${{ github.event.issue.number }}"
27+
link="https://github.com/${{ github.repository }}/issues/$number"
28+
echo "message=The issue (#$number) requires review from Node.js maintainers. See: $link" >> "$GITHUB_OUTPUT"
29+
echo "title=${{ github.actor }} asks for attention on issue #$number" >> "$GITHUB_OUTPUT"
2630
fi
2731
2832
- name: Slack Notification
2933
uses: rtCamp/action-slack-notify@4e5fb42d249be6a45a298f3c9543b111b02f7907 # 2.3.0
3034
env:
3135
SLACK_COLOR: '#DE512A'
3236
SLACK_ICON: https://github.com/nodejs.png?size=48
33-
SLACK_TITLE: ${{ github.actor }} asks for review on ${{ steps.check_pr_or_issue.outputs.type == 'pull_request' && 'PR' || 'Issue' }} #${{ steps.check_pr_or_issue.outputs.number }}
34-
SLACK_MESSAGE: |
35-
This ${{ steps.check_pr_or_issue.outputs.type == 'pull_request' && 'PR' || 'Issue' }} requires review from Node.js maintainers <https://github.com/${{ github.repository }}/pull/${{ steps.check_pr_or_issue.outputs.number }}|#${{ steps.check_pr_or_issue.outputs.number }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
37+
SLACK_TITLE: ${{ steps.define-message.outputs.title }}
38+
SLACK_MESSAGE: ${{ steps.define-message.outputs.message }}
3639
SLACK_USERNAME: nodejs-bot
3740
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

0 commit comments

Comments
 (0)