Skip to content

Commit 2359273

Browse files
ulisesantanaMylesBorins
authored andcommitted
test: fix arguments order in assert.strictEqual()
PR-URL: #24192 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 3bb6372 commit 2359273

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

test/parallel/test-http-1.0.js

+17-17
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ function test(handler, request_generator, response_validator) {
5858

5959
{
6060
function handler(req, res) {
61-
assert.strictEqual('1.0', req.httpVersion);
62-
assert.strictEqual(1, req.httpVersionMajor);
63-
assert.strictEqual(0, req.httpVersionMinor);
61+
assert.strictEqual(req.httpVersion, '1.0');
62+
assert.strictEqual(req.httpVersionMajor, 1);
63+
assert.strictEqual(req.httpVersionMinor, 0);
6464
res.writeHead(200, { 'Content-Type': 'text/plain' });
6565
res.end(body);
6666
}
@@ -72,8 +72,8 @@ function test(handler, request_generator, response_validator) {
7272
function response_validator(server_response, client_got_eof, timed_out) {
7373
const m = server_response.split('\r\n\r\n');
7474
assert.strictEqual(m[1], body);
75-
assert.strictEqual(true, client_got_eof);
76-
assert.strictEqual(false, timed_out);
75+
assert.strictEqual(client_got_eof, true);
76+
assert.strictEqual(timed_out, false);
7777
}
7878

7979
test(handler, request_generator, response_validator);
@@ -86,9 +86,9 @@ function test(handler, request_generator, response_validator) {
8686
//
8787
{
8888
function handler(req, res) {
89-
assert.strictEqual('1.0', req.httpVersion);
90-
assert.strictEqual(1, req.httpVersionMajor);
91-
assert.strictEqual(0, req.httpVersionMinor);
89+
assert.strictEqual(req.httpVersion, '1.0');
90+
assert.strictEqual(req.httpVersionMajor, 1);
91+
assert.strictEqual(req.httpVersionMinor, 0);
9292
res.sendDate = false;
9393
res.writeHead(200, { 'Content-Type': 'text/plain' });
9494
res.write('Hello, '); res._send('');
@@ -112,19 +112,19 @@ function test(handler, request_generator, response_validator) {
112112
'\r\n' +
113113
'Hello, world!';
114114

115-
assert.strictEqual(expected_response, server_response);
116-
assert.strictEqual(true, client_got_eof);
117-
assert.strictEqual(false, timed_out);
115+
assert.strictEqual(server_response, expected_response);
116+
assert.strictEqual(client_got_eof, true);
117+
assert.strictEqual(timed_out, false);
118118
}
119119

120120
test(handler, request_generator, response_validator);
121121
}
122122

123123
{
124124
function handler(req, res) {
125-
assert.strictEqual('1.1', req.httpVersion);
126-
assert.strictEqual(1, req.httpVersionMajor);
127-
assert.strictEqual(1, req.httpVersionMinor);
125+
assert.strictEqual(req.httpVersion, '1.1');
126+
assert.strictEqual(req.httpVersionMajor, 1);
127+
assert.strictEqual(req.httpVersionMinor, 1);
128128
res.sendDate = false;
129129
res.writeHead(200, { 'Content-Type': 'text/plain' });
130130
res.write('Hello, '); res._send('');
@@ -155,9 +155,9 @@ function test(handler, request_generator, response_validator) {
155155
'0\r\n' +
156156
'\r\n';
157157

158-
assert.strictEqual(expected_response, server_response);
159-
assert.strictEqual(true, client_got_eof);
160-
assert.strictEqual(false, timed_out);
158+
assert.strictEqual(server_response, expected_response);
159+
assert.strictEqual(client_got_eof, true);
160+
assert.strictEqual(timed_out, false);
161161
}
162162

163163
test(handler, request_generator, response_validator);

0 commit comments

Comments
 (0)