Skip to content

Commit 239f3ed

Browse files
committed
fixup! module: unflag import assertions
1 parent 74cbfed commit 239f3ed

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

lib/internal/process/esm_loader.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
'use strict';
22

3+
const {
4+
ObjectCreate,
5+
} = primordials;
6+
37
const {
48
ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING,
59
} = require('internal/errors').codes;
@@ -55,7 +59,8 @@ async function initializeLoader() {
5559
emitExperimentalWarning('--experimental-loader');
5660
return (async () => {
5761
const hooks =
58-
await ESMLoader.import(userLoader, pathToFileURL(cwd).href, ObjectCreate(null));
62+
await ESMLoader.import(userLoader, pathToFileURL(cwd).href,
63+
ObjectCreate(null));
5964
ESMLoader = new Loader();
6065
ESMLoader.hook(hooks);
6166
ESMLoader.runGlobalPreloadCode();

lib/repl.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,9 @@ function REPLServer(prompt,
454454
vm.createScript(fallbackCode, {
455455
filename: file,
456456
displayErrors: true,
457-
importModuleDynamically: async (specifier, _, import_assertions) => {
457+
importModuleDynamically: async (specifier, _, import_assert) => {
458458
return asyncESM.ESMLoader.import(specifier, parentURL,
459-
import_assertions);
459+
import_assert);
460460
}
461461
});
462462
} catch (fallbackError) {
@@ -497,9 +497,9 @@ function REPLServer(prompt,
497497
script = vm.createScript(code, {
498498
filename: file,
499499
displayErrors: true,
500-
importModuleDynamically: async (specifier, _, import_asssertions) => {
500+
importModuleDynamically: async (specifier, _, import_assert) => {
501501
return asyncESM.ESMLoader.import(specifier, parentURL,
502-
import_asssertions);
502+
import_assert);
503503
}
504504
});
505505
} catch (e) {

test/message/esm_import_assertion_failing.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ TypeError [ERR_FAILED_IMPORT_ASSERTION]: Failed to load module "data:text/javasc
66
at new NodeError (node:internal/errors:*:*)
77
at Loader.getModuleJob (node:internal/modules/esm/loader:*:*)
88
at async ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:*:*)
9-
at async Promise.all (index 0)
9+
at async Promise.all (index 1)
1010
at async link (node:internal/modules/esm/module_job:*:*) {
1111
code: 'ERR_FAILED_IMPORT_ASSERTION'
1212
}

0 commit comments

Comments
 (0)