Skip to content

Commit 23e4afc

Browse files
committed
doc: clarify release process for new releasers
1 parent adef64c commit 23e4afc

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

doc/contributing/releases.md

+27-1
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,23 @@ testing is required. Use this opportunity particularly to test macOS and Windows
448448
installers if there are any concerns. Click through to the individual workers
449449
for a run to find the artifacts.
450450

451+
Release build list
452+
453+
| name | OS |
454+
| ------------------------------------------ | ------------- |
455+
| rhel8-release-sources | Linux x64 |
456+
| osx1015-release-tar | macOS 10.15 |
457+
| vs2019-x64 | Windows x64 |
458+
| cross-compiler-rhel8-arm7-gcc-8-glibc-2.28 | Linux ARMv7 |
459+
| rhel8-s390x-release | Linux s390x |
460+
| vs2019-x86 | Windows x86 |
461+
| aix72-ppc64 | AIX 7.2 |
462+
| rhel8-ppc64le-release | Linux ppc64le |
463+
| rhel8-x64-release | Linux x64 |
464+
| osx11-release-tar | macOS 11 |
465+
| rhel8-arm64-release | Linux ARM64 |
466+
| osx11-release-pkg | macOS 11 |
467+
451468
All release workers should achieve "SUCCESS" (and be green, not red). A release
452469
with failures should not be promoted as there are likely problems to be
453470
investigated.
@@ -468,7 +485,14 @@ failed build if you start again!
468485
Jenkins collects the artifacts from the builds, allowing you to download and
469486
install the new build. Make sure that the build appears correct. Check the
470487
version numbers, and perform some basic checks to confirm that all is well with
471-
the build before moving forward.
488+
the build before moving forward. Use the following list as a baseline:
489+
490+
* `process.version` is as expected
491+
* `process.release` is as expected
492+
* `process.versions` is as expected (for example, `openssl` or `llhttp` version
493+
must be in the expected updated version)
494+
* npm version (check it matches what we expect)
495+
* Basic usage to confirm the binary works (`console.log` and global methods)
472496

473497
### 11. Tag and sign the release commit
474498

@@ -510,6 +534,8 @@ include the release code name.
510534
The tag **must** be signed using the GPG key that's listed for you on the
511535
project README.
512536

537+
**Note**: Don't push the tag to remote at this point.
538+
513539
### 12. Set up for the next release
514540

515541
On release proposal branch, edit `src/node_version.h` again and:

0 commit comments

Comments
 (0)