Skip to content

Commit 23f66b1

Browse files
joyeecheungRafaelGSS
authored andcommitted
test: move test-shadow-realm-gc.js to known_issues
There is actually a leak. The test doesn't exercise the right path to create a substantial enough object graph (e.g. accessing something that results in the loading of a binding). This does something more complicated in the test and moves it to known_issues until we find a fix. PR-URL: #47355 Refs: #47353 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 8e6ee53 commit 23f66b1

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

test/known_issues/known_issues.status

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ prefix known_issues
1111
# foreseeable future. The test itself is flaky and skipped. It
1212
# serves as a demonstration of the issue only.
1313
test-vm-timeout-escape-queuemicrotask: SKIP
14+
# Skipping it because it crashes out of OOM instead of exiting.
15+
# https://github.com/nodejs/node/issues/47353
16+
test-shadow-realm-gc: SKIP
1417

1518
[$system==win32]
1619

test/parallel/test-shadow-realm-gc.js test/known_issues/test-shadow-realm-gc.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@
88
require('../common');
99

1010
for (let i = 0; i < 1000; i++) {
11-
new ShadowRealm();
11+
const realm = new ShadowRealm();
12+
realm.evaluate('new TextEncoder(); 1;');
1213
}

0 commit comments

Comments
 (0)