Skip to content

Commit 247ea55

Browse files
committed
deps: backport 958b761 from upstream V8
Original commit message: [postmortem] add postmortem metadata for symbols As discussed in nodejs/llnode#156, we need postmortem metadata for Symbols to properly print Symbol property names in postmortem debugging tools. Patch suggested by Ben Noordhuis (nodejs/llnode#156 (comment)). [email protected], [email protected] Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 Reviewed-on: https://chromium-review.googlesource.com/1205052 Reviewed-by: Benedikt Meurer <[email protected]> Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#55632} Refs: v8/v8@958b761 PR-URL: #22914 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 65366ad commit 247ea55

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
# Reset this number to 0 on major V8 upgrades.
3535
# Increment by one for each non-official patch applied to deps/v8.
36-
'v8_embedder_string': '-node.3',
36+
'v8_embedder_string': '-node.4',
3737

3838
# Enable disassembler for `--print-code` v8 options
3939
'v8_enable_disassembler': 1,

deps/v8/BUILD.gn

+2
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,8 @@ action("postmortem-metadata") {
865865
"src/objects/js-regexp-string-iterator.h",
866866
"src/objects/map.h",
867867
"src/objects/map-inl.h",
868+
"src/objects/name.h",
869+
"src/objects/name-inl.h",
868870
"src/objects/scope-info.h",
869871
"src/objects/script.h",
870872
"src/objects/script-inl.h",

deps/v8/gypfiles/v8.gyp

+2
Original file line numberDiff line numberDiff line change
@@ -2649,6 +2649,8 @@
26492649
'../src/objects/js-regexp-string-iterator.h',
26502650
'../src/objects/map.h',
26512651
'../src/objects/map-inl.h',
2652+
'../src/objects/name.h',
2653+
'../src/objects/name-inl.h',
26522654
'../src/objects/scope-info.h',
26532655
'../src/objects/script.h',
26542656
'../src/objects/script-inl.h',

deps/v8/tools/gen-postmortem-metadata.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -417,15 +417,10 @@ def load_objects_from_file(objfilename, checktypes):
417417
# way around.
418418
#
419419
for type in types:
420-
#
421-
# Symbols and Strings are implemented using the same classes.
422-
#
423-
usetype = re.sub('SYMBOL_', 'STRING_', type);
424-
425420
#
426421
# REGEXP behaves like REG_EXP, as in JS_REGEXP_TYPE => JSRegExp.
427422
#
428-
usetype = re.sub('_REGEXP_', '_REG_EXP_', usetype);
423+
usetype = re.sub('_REGEXP_', '_REG_EXP_', type);
429424

430425
#
431426
# Remove the "_TYPE" suffix and then convert to camel case,

0 commit comments

Comments
 (0)