Skip to content

Commit 25109a6

Browse files
benjamingrdanielleadams
authored andcommitted
test: improve stability of oom test
The OOM test uses a value that caused an OOM crash from V8 on certain machines when V8 did not notify the host of OOM soon enough. PR-URL: #41681 Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 60e28ba commit 25109a6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-windows-failed-heap-allocation.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const tmpdir = require('../common/tmpdir');
1919
tmpdir.refresh();
2020

2121
// --max-old-space-size=3 is the min 'old space' in V8, explodes fast
22-
const cmd = `"${process.execPath}" --max-old-space-size=3 "${__filename}"`;
23-
exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err) => {
22+
const cmd = `"${process.execPath}" --max-old-space-size=30 "${__filename}"`;
23+
exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err, stdout, stderr) => {
2424
const msg = `Wrong exit code of ${err.code}! Expected 134 for abort`;
2525
// Note: common.nodeProcessAborted() is not asserted here because it
2626
// returns true on 134 as well as 0x80000003 (V8's base::OS::Abort)

0 commit comments

Comments
 (0)