Skip to content

Commit 254810a

Browse files
danbevtargos
authored andcommitted
doc: add duplicate CVE check in sec. release doc
This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: #39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent c968372 commit 254810a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

doc/guides/security-release-process.md

+3
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ information described.
4040
* Approved
4141
* Pass `make test`
4242
* Have CVEs
43+
* Make sure that dependent libraries have CVEs for their issues. We should
44+
only create CVEs for vulnerabilities in Node.js itself. This is to avoid
45+
having duplicate CVEs for the same vulnerability.
4346
* Described in the pre/post announcements
4447
4548
* [ ] Pre-release announcement [email][]: ***LINK TO EMAIL***

0 commit comments

Comments
 (0)