Skip to content

Commit 26e695c

Browse files
TrottMylesBorins
authored andcommitted
doc: remove "feature branch" jargon
In the context of the CONTRIBUTING.md document, there is no advantage to describing the branch as a "feature branch" and the term may be confusing. Just refer to it as a branch. Context for the curious: The phrase "feature branch" in CONTIRUBTING.md confused someone I was assisting today. It occured to me that the word "feature" doesn't add anything and can be confusing. ("I'm doing a bug fix so I don't need to create a feature branch, right?") PR-URL: #8194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent d676467 commit 26e695c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ does not align with the project team. Node.js has two IRC channels,
7575

7676
### Step 2: Branch
7777

78-
Create a feature branch and start hacking:
78+
Create a branch and start hacking:
7979

8080
```text
81-
$ git checkout -b my-feature-branch -t origin/master
81+
$ git checkout -b my-branch -t origin/master
8282
```
8383

8484
### Step 3: Commit
@@ -185,15 +185,15 @@ core modules.
185185
### Step 6: Push
186186

187187
```text
188-
$ git push origin my-feature-branch
188+
$ git push origin my-branch
189189
```
190190

191-
Go to https://github.com/yourusername/node and select your feature branch.
191+
Go to https://github.com/yourusername/node and select your branch.
192192
Click the 'Pull Request' button and fill out the form.
193193

194194
Pull requests are usually reviewed within a few days. If there are comments
195195
to address, apply your changes in a separate commit and push that to your
196-
feature branch. Post a comment in the pull request afterwards; GitHub does
196+
branch. Post a comment in the pull request afterwards; GitHub does
197197
not send out notifications when you add commits.
198198

199199
<a id="developers-certificate-of-origin"></a>

0 commit comments

Comments
 (0)