Skip to content

Commit 26e7374

Browse files
joaocgreisMylesBorins
authored andcommitted
win,build: exit when addons fail to build
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 30e751f commit 26e7374

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

vcbuild.bat

+4
Original file line numberDiff line numberDiff line change
@@ -336,12 +336,16 @@ for /d %%F in (test\addons\??_*) do (
336336
)
337337
:: generate
338338
"%node_exe%" tools\doc\addon-verify.js
339+
if %errorlevel% neq 0 exit /b %errorlevel%
339340
:: building addons
341+
SetLocal EnableDelayedExpansion
340342
for /d %%F in (test\addons\*) do (
341343
"%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild ^
342344
--directory="%%F" ^
343345
--nodedir="%cd%"
346+
if !errorlevel! neq 0 exit /b !errorlevel!
344347
)
348+
EndLocal
345349
goto run-tests
346350

347351
:run-tests

0 commit comments

Comments
 (0)