Skip to content

Commit 2783d2d

Browse files
danbevgibfahn
authored andcommitted
doc: add missing make command to UPGRADING.md
Added the missing make command in steps 6.3 when building asm_obsolete. Also updated the commit message to include the version nasm in addition to the gcc version. Fixes: #13161 PR-URL: #13233 Backport-PR-URL: #13695 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 0a04418 commit 2783d2d

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

deps/openssl/doc/UPGRADING.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -346,13 +346,16 @@ ohtsu@ubuntu:~/github/node/deps/openssl/asm_obsolete$ make clean
346346
find . -iname '*.asm' -exec rm "{}" \;
347347
find . -iname '*.s' -exec rm "{}" \;
348348
find . -iname '*.S' -exec rm "{}" \;
349+
ohtsu@ubuntu:~/github/node/deps/openssl/asm_obsolete$ make
349350
ohtsu@ubuntu:~/github/node/deps/openssl$ git status
350351
ohtsu@ubuntu:~/github/node/deps/openssl$ git commit asm asm_obsolete
351352
````
352353
The commit message can be
353354
354355
>deps: update openssl asm and asm_obsolete files
355356
>
356-
>Regenerate asm files with Makefile and CC=gcc and ASM=gcc where
357-
>gcc-4.8.4. Also asm files in asm_obsolete dir to support old compiler
358-
>and assembler are regenerated without CC and ASM envs.
357+
>Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
358+
>version was 5.4.0 and nasm version was 2.11.08.
359+
>
360+
>Also asm files in asm_obsolete dir to support old compiler and
361+
>assembler are regenerated without CC and ASM envs.

0 commit comments

Comments
 (0)