Skip to content

Commit 2853b76

Browse files
committed
build: add pummel tests to ci runs
PR-URL: #34289 Reviewed-By: Richard Lau <[email protected]>
1 parent 24426cd commit 2853b76

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

Diff for: Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ JS_SUITES ?= default
478478
NATIVE_SUITES ?= addons js-native-api node-api
479479
# CI_* variables should be kept synchronized with the ones in vcbuild.bat
480480
CI_NATIVE_SUITES ?= $(NATIVE_SUITES) benchmark
481-
CI_JS_SUITES ?= $(JS_SUITES)
481+
CI_JS_SUITES ?= $(JS_SUITES) pummel
482482
ifeq ($(node_use_openssl), false)
483483
CI_DOC := doctool
484484
else

Diff for: tools/test.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ def RunCommand(self, command, env):
574574
full_command = self.context.processor(command)
575575
output = Execute(full_command,
576576
self.context,
577-
self.context.GetTimeout(self.mode),
577+
self.context.GetTimeout(self.mode, self.config.section),
578578
env,
579579
disable_core_files = self.disable_core_files)
580580
return TestOutput(self,
@@ -940,8 +940,11 @@ def GetVm(self, arch, mode):
940940

941941
return name
942942

943-
def GetTimeout(self, mode):
944-
return self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
943+
def GetTimeout(self, mode, section=''):
944+
timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
945+
if section == 'pummel':
946+
timeout = timeout * 4
947+
return timeout
945948

946949
def RunTestCases(cases_to_run, progress, tasks, flaky_tests_mode):
947950
progress = PROGRESS_INDICATORS[progress](cases_to_run, flaky_tests_mode)

Diff for: vcbuild.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ set JS_SUITES=default
1919
set NATIVE_SUITES=addons js-native-api node-api
2020
@rem CI_* variables should be kept synchronized with the ones in Makefile
2121
set "CI_NATIVE_SUITES=%NATIVE_SUITES% benchmark"
22-
set "CI_JS_SUITES=%JS_SUITES%"
22+
set "CI_JS_SUITES=%JS_SUITES% pummel"
2323
set CI_DOC=doctool
2424
@rem Same as the test-ci target in Makefile
2525
set "common_test_suites=%JS_SUITES% %NATIVE_SUITES%&set build_addons=1&set build_js_native_api_tests=1&set build_node_api_tests=1"

0 commit comments

Comments
 (0)