Skip to content

Commit 2a7835c

Browse files
joyeecheungRafaelGSS
authored andcommitted
deps: V8: cherry-pick 9f4b7699f68e
Original commit message: Fix mistake in the skip branch of test/mjsunit/regress-1320641.js It was doing a `string.test(regex)` which was wrong. It's supposed to be `regex.test(string)`. It wasn't caught in the CI because the skip path is not normally taken in the V8 CI. Change-Id: Id1bdab5bbc41968bba8adc1cb3664e8f95fb5d72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4697855 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#89044} Refs: v8/v8@9f4b769 PR-URL: #48830 Refs: v8/v8@c1a54d5 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
1 parent c8e1782 commit 2a7835c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.12',
39+
'v8_embedder_string': '-node.13',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/test/mjsunit/regress/regress-1320641.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var skip = false;
1313
try {
1414
new Uint16Array(3775336418);
1515
} catch (e) {
16-
if (e.message.test(/Array buffer allocation failed/)) {
16+
if (/Array buffer allocation failed/.test(e.message)) {
1717
skip = true; // We don't have enough memory, just skip the test.
1818
}
1919
}

0 commit comments

Comments
 (0)