Skip to content

Commit 2afa543

Browse files
ofrobotsrvagg
authored andcommitted
src: enable vector ics on arm again
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 28e39d6 commit 2afa543

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/node.cc

-5
Original file line numberDiff line numberDiff line change
@@ -3615,11 +3615,6 @@ void Init(int* argc,
36153615
// TODO(bnoordhuis): Remove test/parallel/test-arm-math-exp-regress-1376.js
36163616
// and this workaround when v8:4019 has been fixed and the patch back-ported.
36173617
V8::SetFlagsFromString("--nofast_math", sizeof("--nofast_math") - 1);
3618-
// See https://github.com/nodejs/node/pull/2220#issuecomment-126200059
3619-
// and https://code.google.com/p/v8/issues/detail?id=4338
3620-
// TODO(targos): Remove this workaround when v8:4338 has been fixed and the
3621-
// patch back-ported.
3622-
V8::SetFlagsFromString("--novector_ics", sizeof("--novector_ics") - 1);
36233618
#endif
36243619

36253620
#if defined(NODE_V8_OPTIONS)

0 commit comments

Comments
 (0)