Skip to content

Commit 2b01fc6

Browse files
TrottVoltrexKeyva
andcommitted
Update doc/contributing/pull-requests.md
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
1 parent 12bfec2 commit 2b01fc6

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

doc/contributing/pull-requests.md

+6-7
Original file line numberDiff line numberDiff line change
@@ -514,15 +514,14 @@ Only Node.js core collaborators and triagers can start a CI testing run. The
514514
specific details of how to do this are included in the new collaborator
515515
[Onboarding guide][]. Usually, a collaborator or triager will start a CI
516516
test run for you as approvals for the pull request come in.
517-
If not, you can ask a collaborator to start a CI run.
517+
If not, you can ask a collaborator or triager to start a CI run.
518518

519519
Ideally, the code change will pass ("be green") on all platform configurations
520-
supported by Node.js. (There are over 30 platform configurations currently.)
521-
This means that all tests pass and there are no linting errors. In reality,
522-
however, it is not uncommon for the CI infrastructure itself to fail on
523-
specific platforms or for so-called "flaky" tests to fail ("be red"). It is
524-
vital to visually inspect the results of all failed ("red") tests to determine
525-
whether the failure was caused by the changes in the pull request.
520+
supported by Node.js. This means that all tests pass and there are no linting
521+
errors. In reality, however, it is not uncommon for the CI infrastructure itself
522+
to fail on specific platforms or for so-called "flaky" tests to fail ("be red").
523+
It is vital to visually inspect the results of all failed ("red") tests to
524+
determine whether the failure was caused by the changes in the pull request.
526525

527526
## Notes
528527

0 commit comments

Comments
 (0)