Skip to content

Commit 2b1f881

Browse files
ZYSzysaddaleax
authored andcommitted
benchmark: remove unreachable return
PR-URL: #25883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 620d429 commit 2b1f881

File tree

5 files changed

+0
-6
lines changed

5 files changed

+0
-6
lines changed

benchmark/_cli.js

-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ function CLI(usage, settings) {
7070
} else {
7171
// Bad case, abort
7272
this.abort(usage);
73-
return;
7473
}
7574
}
7675
}

benchmark/common.js

-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ Benchmark.prototype._run = function() {
169169
child.on('close', (code) => {
170170
if (code) {
171171
process.exit(code);
172-
return;
173172
}
174173

175174
if (queueIndex + 1 < self.queue.length) {

benchmark/compare.js

-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const cli = CLI(`usage: ./node compare.js [options] [--] <category> ...
2525

2626
if (!cli.optional.new || !cli.optional.old) {
2727
cli.abort(cli.usage);
28-
return;
2928
}
3029

3130
const binaries = ['old', 'new'];
@@ -98,7 +97,6 @@ if (showProgress) {
9897
child.once('close', (code) => {
9998
if (code) {
10099
process.exit(code);
101-
return;
102100
}
103101
if (showProgress) {
104102
progress.completeRun(job);

benchmark/run.js

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ if (format === 'csv') {
6767
child.once('close', (code) => {
6868
if (code) {
6969
process.exit(code);
70-
return;
7170
}
7271

7372
// If there are more benchmarks execute the next

benchmark/scatter.js

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ const cli = CLI(`usage: ./node scatter.js [options] [--] <filename>
1717

1818
if (cli.items.length !== 1) {
1919
cli.abort(cli.usage);
20-
return;
2120
}
2221

2322
// Create queue from the benchmarks list such both node versions are tested

0 commit comments

Comments
 (0)