Skip to content

Commit 2b7e18d

Browse files
tniessentargos
authored andcommitted
win,msi: highlight installation of 3rd-party tools
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script. PR-URL: #23003 Refs: #22645 Refs: #22988 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: João Reis <[email protected]>
1 parent ebf36cd commit 2b7e18d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

tools/msvs/install_tools/install_tools.bat

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ echo Tools for Node.js Native Modules Installation Script
55
echo ====================================================
66
echo.
77
echo This Boxstarter script will install Python and the Visual Studio Build Tools,
8-
echo necessary to compile Node.js native modules. All necessary Windows updates
9-
echo will also be installed.
8+
echo necessary to compile Node.js native modules. Note that Boxstarter,
9+
echo Chocolatey and required Windows updates will also be installed.
1010
echo.
1111
echo This will require about 3 Gb of free disk space, plus any space necessary to
1212
echo install Windows updates.

tools/msvs/msi/i18n/en-us.wxl

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<String Id="NativeToolsDlgDescription">Optionally install the tools necessary to compile native modules.</String>
1414
<String Id="NativeToolsDlgBannerBitmap">WixUI_Bmp_Banner</String>
1515
<String Id="NativeToolsDlgIntro">Some npm modules need to be compiled from C/C++ when installing. If you want to be able to install such modules, some tools (Python 2 and Visual Studio Build Tools) need to be installed.</String>
16-
<String Id="NativeToolsDlgInstallCheckbox">Automatically install the necessary tools. The script will pop-up in a new window after the installation completes.</String>
16+
<String Id="NativeToolsDlgInstallCheckbox">Automatically install the necessary tools. Note that this will also install Boxstarter and Chocolatey. The script will pop-up in a new window after the installation completes.</String>
1717
<String Id="NativeToolsDlgManualDetails">Alternatively, follow the instructions at <![CDATA[<a href="https://github.com/nodejs/node-gyp#on-windows">https://github.com/nodejs/node-gyp#on-windows</a>]]> to install the dependencies yourself.</String>
1818

1919
<!-- References like [ProductName] or $(var.ProductName) don't seem to work in Title attributes -->

0 commit comments

Comments
 (0)