Skip to content

Commit 2c5c2bd

Browse files
Trottjasnell
authored andcommitted
test: check noop invocation with mustNotCall()
In test-child-process-spawnsync-validation-errors, check that functions used inappropriately as options are not invoked. PR-URL: #13205 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 45139e5 commit 2c5c2bd

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/parallel/test-child-process-spawnsync-validation-errors.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function fail(option, value, message) {
3131
fail('cwd', false, err);
3232
fail('cwd', [], err);
3333
fail('cwd', {}, err);
34-
fail('cwd', common.noop, err);
34+
fail('cwd', common.mustNotCall(), err);
3535
}
3636

3737
{
@@ -47,7 +47,7 @@ function fail(option, value, message) {
4747
fail('detached', __dirname, err);
4848
fail('detached', [], err);
4949
fail('detached', {}, err);
50-
fail('detached', common.noop, err);
50+
fail('detached', common.mustNotCall(), err);
5151
}
5252

5353
if (!common.isWindows) {
@@ -64,7 +64,7 @@ if (!common.isWindows) {
6464
fail('uid', false, err);
6565
fail('uid', [], err);
6666
fail('uid', {}, err);
67-
fail('uid', common.noop, err);
67+
fail('uid', common.mustNotCall(), err);
6868
fail('uid', NaN, err);
6969
fail('uid', Infinity, err);
7070
fail('uid', 3.1, err);
@@ -85,7 +85,7 @@ if (!common.isWindows) {
8585
fail('gid', false, err);
8686
fail('gid', [], err);
8787
fail('gid', {}, err);
88-
fail('gid', common.noop, err);
88+
fail('gid', common.mustNotCall(), err);
8989
fail('gid', NaN, err);
9090
fail('gid', Infinity, err);
9191
fail('gid', 3.1, err);
@@ -105,7 +105,7 @@ if (!common.isWindows) {
105105
fail('shell', 1, err);
106106
fail('shell', [], err);
107107
fail('shell', {}, err);
108-
fail('shell', common.noop, err);
108+
fail('shell', common.mustNotCall(), err);
109109
}
110110

111111
{
@@ -121,7 +121,7 @@ if (!common.isWindows) {
121121
fail('argv0', false, err);
122122
fail('argv0', [], err);
123123
fail('argv0', {}, err);
124-
fail('argv0', common.noop, err);
124+
fail('argv0', common.mustNotCall(), err);
125125
}
126126

127127
{
@@ -137,7 +137,7 @@ if (!common.isWindows) {
137137
fail('windowsVerbatimArguments', __dirname, err);
138138
fail('windowsVerbatimArguments', [], err);
139139
fail('windowsVerbatimArguments', {}, err);
140-
fail('windowsVerbatimArguments', common.noop, err);
140+
fail('windowsVerbatimArguments', common.mustNotCall(), err);
141141
}
142142

143143
{
@@ -154,7 +154,7 @@ if (!common.isWindows) {
154154
fail('timeout', __dirname, err);
155155
fail('timeout', [], err);
156156
fail('timeout', {}, err);
157-
fail('timeout', common.noop, err);
157+
fail('timeout', common.mustNotCall(), err);
158158
fail('timeout', NaN, err);
159159
fail('timeout', Infinity, err);
160160
fail('timeout', 3.1, err);
@@ -179,7 +179,7 @@ if (!common.isWindows) {
179179
fail('maxBuffer', __dirname, err);
180180
fail('maxBuffer', [], err);
181181
fail('maxBuffer', {}, err);
182-
fail('maxBuffer', common.noop, err);
182+
fail('maxBuffer', common.mustNotCall(), err);
183183
}
184184

185185
{
@@ -196,7 +196,7 @@ if (!common.isWindows) {
196196
fail('killSignal', false, typeErr);
197197
fail('killSignal', [], typeErr);
198198
fail('killSignal', {}, typeErr);
199-
fail('killSignal', common.noop, typeErr);
199+
fail('killSignal', common.mustNotCall(), typeErr);
200200

201201
// Invalid signal names and numbers should fail
202202
fail('killSignal', 500, unknownSignalErr);

0 commit comments

Comments
 (0)