Skip to content

Commit 2ce4b7c

Browse files
addaleaxMylesBorins
authored andcommitted
build: do not depend on cp in PATH
Use gyp’s own copying mechanism instead. It’s not really clear which UNIX utils exactly are needed to build on Windows, but this is an easier fix (at least for me) than figuring out how to get `cp` into the `PATH` in all cases, and judging from the issue I’m not the only one who ran into this. Fixes: #20272 PR-URL: #20296 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 701f536 commit 2ce4b7c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

node.gyp

+6-6
Original file line numberDiff line numberDiff line change
@@ -680,13 +680,13 @@
680680
'toolsets': ['host'],
681681
'conditions': [
682682
[ 'v8_enable_inspector==1', {
683-
'actions': [
683+
'copies': [
684684
{
685-
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
686-
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
687-
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
688-
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
689-
},
685+
'destination': '<(SHARED_INTERMEDIATE_DIR)',
686+
'files': ['deps/v8/src/inspector/js_protocol.pdl']
687+
}
688+
],
689+
'actions': [
690690
{
691691
'action_name': 'v8_inspector_convert_protocol_to_json',
692692
'inputs': [

0 commit comments

Comments
 (0)