Skip to content

Commit 2da6f62

Browse files
addaleaxtargos
authored andcommitted
src: deprecate UVException() without Isolate*
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde0. PR-URL: #23175 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent e9a0cff commit 2da6f62

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/node.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ NODE_DEPRECATED("Use ErrnoException(isolate, ...)",
139139
path);
140140
})
141141

142-
inline v8::Local<v8::Value> UVException(int errorno,
142+
NODE_DEPRECATED("Use UVException(isolate, ...)",
143+
inline v8::Local<v8::Value> UVException(int errorno,
143144
const char* syscall = nullptr,
144145
const char* message = nullptr,
145146
const char* path = nullptr) {
@@ -148,7 +149,7 @@ inline v8::Local<v8::Value> UVException(int errorno,
148149
syscall,
149150
message,
150151
path);
151-
}
152+
})
152153

153154
/*
154155
* These methods need to be called in a HandleScope.

0 commit comments

Comments
 (0)