Skip to content

Commit 2dad8d4

Browse files
committed
deps: V8: cherry-pick bde7ee5473d6
Original commit message: cppgc: avoid multiple class declarations ConcurrentMarkingState and MarkingStateBase are already defined in the This change fixes compilation with MSVC. v8: :internal namespace. Change-Id: Ib8a1370a0a27a90e385fd69e61036e263e1489e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562671 Reviewed-by: Omer Katz <[email protected]> Commit-Queue: Michaël Zasso <[email protected]> Cr-Commit-Position: refs/heads/master@{#71473} Refs: v8/v8@bde7ee5 PR-URL: #36139 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
1 parent 3046131 commit 2dad8d4

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

Diff for: common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.14',
39+
'v8_embedder_string': '-node.15',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: deps/v8/src/heap/cppgc-js/cpp-heap.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,15 @@ class UnifiedHeapConcurrentMarker
8181
unified_heap_marking_state_(unified_heap_marking_state) {}
8282

8383
std::unique_ptr<cppgc::Visitor> CreateConcurrentMarkingVisitor(
84-
ConcurrentMarkingState&) const final;
84+
cppgc::internal::ConcurrentMarkingState&) const final;
8585

8686
private:
8787
UnifiedHeapMarkingState& unified_heap_marking_state_;
8888
};
8989

9090
std::unique_ptr<cppgc::Visitor>
9191
UnifiedHeapConcurrentMarker::CreateConcurrentMarkingVisitor(
92-
ConcurrentMarkingState& marking_state) const {
92+
cppgc::internal::ConcurrentMarkingState& marking_state) const {
9393
return std::make_unique<ConcurrentUnifiedHeapMarkingVisitor>(
9494
heap(), marking_state, unified_heap_marking_state_);
9595
}

Diff for: deps/v8/src/heap/cppgc-js/unified-heap-marking-visitor.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace v8 {
1414
namespace internal {
1515

1616
UnifiedHeapMarkingVisitorBase::UnifiedHeapMarkingVisitorBase(
17-
HeapBase& heap, MarkingStateBase& marking_state,
17+
HeapBase& heap, cppgc::internal::MarkingStateBase& marking_state,
1818
UnifiedHeapMarkingState& unified_heap_marking_state)
1919
: JSVisitor(cppgc::internal::VisitorFactory::CreateKey()),
2020
marking_state_(marking_state),
@@ -89,7 +89,7 @@ void MutatorUnifiedHeapMarkingVisitor::VisitWeakRoot(const void* object,
8989
}
9090

9191
ConcurrentUnifiedHeapMarkingVisitor::ConcurrentUnifiedHeapMarkingVisitor(
92-
HeapBase& heap, ConcurrentMarkingState& marking_state,
92+
HeapBase& heap, cppgc::internal::ConcurrentMarkingState& marking_state,
9393
UnifiedHeapMarkingState& unified_heap_marking_state)
9494
: UnifiedHeapMarkingVisitorBase(heap, marking_state,
9595
unified_heap_marking_state) {}
@@ -99,7 +99,7 @@ bool ConcurrentUnifiedHeapMarkingVisitor::DeferTraceToMutatorThreadIfConcurrent(
9999
size_t deferred_size) {
100100
marking_state_.concurrent_marking_bailout_worklist().Push(
101101
{parameter, callback, deferred_size});
102-
static_cast<ConcurrentMarkingState&>(marking_state_)
102+
static_cast<cppgc::internal::ConcurrentMarkingState&>(marking_state_)
103103
.AccountDeferredMarkedBytes(deferred_size);
104104
return true;
105105
}

Diff for: deps/v8/src/heap/cppgc-js/unified-heap-marking-visitor.h

+4-5
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,12 @@ namespace internal {
2828
using cppgc::SourceLocation;
2929
using cppgc::TraceDescriptor;
3030
using cppgc::WeakCallback;
31-
using cppgc::internal::ConcurrentMarkingState;
3231
using cppgc::internal::HeapBase;
33-
using cppgc::internal::MarkingStateBase;
3432
using cppgc::internal::MutatorMarkingState;
3533

3634
class V8_EXPORT_PRIVATE UnifiedHeapMarkingVisitorBase : public JSVisitor {
3735
public:
38-
UnifiedHeapMarkingVisitorBase(HeapBase&, MarkingStateBase&,
36+
UnifiedHeapMarkingVisitorBase(HeapBase&, cppgc::internal::MarkingStateBase&,
3937
UnifiedHeapMarkingState&);
4038
~UnifiedHeapMarkingVisitorBase() override = default;
4139

@@ -53,7 +51,7 @@ class V8_EXPORT_PRIVATE UnifiedHeapMarkingVisitorBase : public JSVisitor {
5351
// JS handling.
5452
void Visit(const TracedReferenceBase& ref) final;
5553

56-
MarkingStateBase& marking_state_;
54+
cppgc::internal::MarkingStateBase& marking_state_;
5755
UnifiedHeapMarkingState& unified_heap_marking_state_;
5856
};
5957

@@ -73,7 +71,8 @@ class V8_EXPORT_PRIVATE MutatorUnifiedHeapMarkingVisitor final
7371
class V8_EXPORT_PRIVATE ConcurrentUnifiedHeapMarkingVisitor final
7472
: public UnifiedHeapMarkingVisitorBase {
7573
public:
76-
ConcurrentUnifiedHeapMarkingVisitor(HeapBase&, ConcurrentMarkingState&,
74+
ConcurrentUnifiedHeapMarkingVisitor(HeapBase&,
75+
cppgc::internal::ConcurrentMarkingState&,
7776
UnifiedHeapMarkingState&);
7877
~ConcurrentUnifiedHeapMarkingVisitor() override = default;
7978

0 commit comments

Comments
 (0)