Skip to content

Commit 2db83fd

Browse files
ceccodeaddaleax
authored andcommitted
test: remove deepStrictEqual() third argument
The call to assert.deepStrictEqual() has a string literal for its third argument. Unfortunately, a side effect of that is that the values of the first two arguments are not displayed if there is an AssertionError. That information is useful for debugging. PR-URL: #20702 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent ebc1b77 commit 2db83fd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-net-socket-local-address.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ const server = net.createServer((socket) => {
1717
});
1818

1919
server.on('close', common.mustCall(() => {
20-
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts,
21-
'client and server should agree on the ports used');
20+
// client and server should agree on the ports used
21+
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
2222
assert.strictEqual(2, conns);
2323
}));
2424

0 commit comments

Comments
 (0)