Skip to content

Commit 2dd157f

Browse files
cjihrigtargos
authored andcommitted
cluster: use Map to track indexes
PR-URL: #23125 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
1 parent 64f840a commit 2dd157f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

lib/internal/cluster/child.js

+11-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const Worker = require('internal/cluster/worker');
88
const { internal, sendHelper } = require('internal/cluster/utils');
99
const cluster = new EventEmitter();
1010
const handles = {};
11-
const indexes = {};
11+
const indexes = new Map();
1212
const noop = () => {};
1313

1414
module.exports = cluster;
@@ -62,14 +62,18 @@ cluster._getServer = function(obj, options, cb) {
6262
options.addressType,
6363
options.fd ].join(':');
6464

65-
if (indexes[indexesKey] === undefined)
66-
indexes[indexesKey] = 0;
65+
let index = indexes.get(indexesKey);
66+
67+
if (index === undefined)
68+
index = 0;
6769
else
68-
indexes[indexesKey]++;
70+
index++;
71+
72+
indexes.set(indexesKey, index);
6973

7074
const message = util._extend({
7175
act: 'queryServer',
72-
index: indexes[indexesKey],
76+
index,
7377
data: null
7478
}, options);
7579

@@ -108,7 +112,7 @@ function shared(message, handle, indexesKey, cb) {
108112
handle.close = function() {
109113
send({ act: 'close', key });
110114
delete handles[key];
111-
delete indexes[indexesKey];
115+
indexes.delete(indexesKey);
112116
return close.apply(this, arguments);
113117
}.bind(handle);
114118
assert(handles[key] === undefined);
@@ -141,7 +145,7 @@ function rr(message, indexesKey, cb) {
141145

142146
send({ act: 'close', key });
143147
delete handles[key];
144-
delete indexes[indexesKey];
148+
indexes.delete(indexesKey);
145149
key = undefined;
146150
}
147151

0 commit comments

Comments
 (0)