Skip to content

Commit 2f8aa88

Browse files
TrottMylesBorins
authored andcommitted
test: use mustNotCall() in test-fs-watch
Use common.mustNotCall() in test/sequential/test-fs-watch.js in situations where the call to watch() is expected to throw. PR-URL: #13595 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 6f44563 commit 2f8aa88

File tree

1 file changed

+23
-2
lines changed

1 file changed

+23
-2
lines changed

test/sequential/test-fs-watch.js

+23-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
122
'use strict';
223
const common = require('../common');
324
const assert = require('assert');
@@ -109,15 +130,15 @@ fs.watch(__filename, {persistent: false}, function() {
109130
// https://github.com/joyent/node/issues/6690
110131
let oldhandle;
111132
assert.throws(function() {
112-
const w = fs.watch(__filename, function(event, filename) { });
133+
const w = fs.watch(__filename, common.mustNotCall());
113134
oldhandle = w._handle;
114135
w._handle = { close: w._handle.close };
115136
w.close();
116137
}, /^TypeError: Illegal invocation$/);
117138
oldhandle.close(); // clean up
118139

119140
assert.throws(function() {
120-
const w = fs.watchFile(__filename, {persistent: false}, common.noop);
141+
const w = fs.watchFile(__filename, {persistent: false}, common.mustNotCall());
121142
oldhandle = w._handle;
122143
w._handle = { stop: w._handle.stop };
123144
w.stop();

0 commit comments

Comments
 (0)