src: remove unused misc variable

danbev · targos · commit 308be6ca0c45 · 2020-06-02T20:21:49.000+02:00
This commit removes the unused 'misc' variable from one of the NodeMainInstance constructors. Another option could be to add a default argument to SetIsolateMiscHandlers but I'd like to hear what others think about that first. PR-URL: #33417 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc
@@ -39,8 +39,7 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate,
   isolate_data_ =
       std::make_unique<IsolateData>(isolate_, event_loop, platform, nullptr);
 
-  IsolateSettings misc;
-  SetIsolateMiscHandlers(isolate_, misc);
+  SetIsolateMiscHandlers(isolate_, {});
 }
 
 std::unique_ptr<NodeMainInstance> NodeMainInstance::Create(

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,7 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate,`
`39`	`39`	`isolate_data_ =`
`40`	`40`	`std::make_unique<IsolateData>(isolate_, event_loop, platform, nullptr);`
`41`	`41`
`42`		`- IsolateSettings misc;`
`43`		`- SetIsolateMiscHandlers(isolate_, misc);`
	`42`	`+ SetIsolateMiscHandlers(isolate_, {});`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`std::unique_ptr<NodeMainInstance> NodeMainInstance::Create(`