Skip to content

Commit 3114349

Browse files
RobotMermaidevanlucas
authored andcommitted
test: cleanup test-fs-watch.js
Reversed "actual" and "expected" arguments for assert.strictEqual(). Replaced constructor with regular expression for assert.throws(). PR-URL: #12595 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 29641c8 commit 3114349

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/sequential/test-fs-watch.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ assert.doesNotThrow(
3636
function() {
3737
const watcher = fs.watch(filepathOne);
3838
watcher.on('change', function(event, filename) {
39-
assert.strictEqual('change', event);
39+
assert.strictEqual(event, 'change');
4040

4141
if (expectFilePath) {
42-
assert.strictEqual('watch.txt', filename);
42+
assert.strictEqual(filename, 'watch.txt');
4343
}
4444
watcher.close();
4545
++watchSeenOne;
@@ -59,10 +59,10 @@ fs.writeFileSync(filepathTwoAbs, 'howdy');
5959
assert.doesNotThrow(
6060
function() {
6161
const watcher = fs.watch(filepathTwo, function(event, filename) {
62-
assert.strictEqual('change', event);
62+
assert.strictEqual(event, 'change');
6363

6464
if (expectFilePath) {
65-
assert.strictEqual('hasOwnProperty', filename);
65+
assert.strictEqual(filename, 'hasOwnProperty');
6666
}
6767
watcher.close();
6868
++watchSeenTwo;
@@ -82,11 +82,11 @@ assert.doesNotThrow(
8282
function() {
8383
const watcher = fs.watch(testsubdir, function(event, filename) {
8484
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
85-
assert.strictEqual(renameEv, event);
85+
assert.strictEqual(event, renameEv);
8686
if (expectFilePath) {
87-
assert.strictEqual('newfile.txt', filename);
87+
assert.strictEqual(filename, 'newfile.txt');
8888
} else {
89-
assert.strictEqual(null, filename);
89+
assert.strictEqual(filename, null);
9090
}
9191
watcher.close();
9292
++watchSeenThree;
@@ -113,13 +113,13 @@ assert.throws(function() {
113113
oldhandle = w._handle;
114114
w._handle = { close: w._handle.close };
115115
w.close();
116-
}, TypeError);
116+
}, /^TypeError: Illegal invocation$/);
117117
oldhandle.close(); // clean up
118118

119119
assert.throws(function() {
120120
const w = fs.watchFile(__filename, {persistent: false}, function() {});
121121
oldhandle = w._handle;
122122
w._handle = { stop: w._handle.stop };
123123
w.stop();
124-
}, TypeError);
124+
}, /^TypeError: Illegal invocation$/);
125125
oldhandle.stop(); // clean up

0 commit comments

Comments
 (0)