lib: enforce use of Promise from primordials

PR-URL: #30936
Refs: #30697
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

Author: targos

lib/.eslintrc.yaml

@@ -23,6 +23,8 @@ rules:
       message: "Use `const { Number } = primordials;` instead of the global."
     - name: Object
       message: "Use `const { Object } = primordials;` instead of the global."
+    - name: Promise
+      message: "Use `const { Promise } = primordials;` instead of the global."
     - name: Reflect
       message: "Use `const { Reflect } = primordials;` instead of the global."
     - name: Symbol

lib/child_process.js

@@ -27,6 +27,7 @@ const {
   ObjectAssign,
   ObjectDefineProperty,
   ObjectPrototypeHasOwnProperty,
+  Promise,
 } = primordials;
 
 const {

lib/events.js

@@ -29,6 +29,7 @@ const {
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
   ObjectKeys,
+  Promise,
   ReflectApply,
   ReflectOwnKeys,
 } = primordials;

lib/fs.js

@@ -30,6 +30,7 @@ const {
   ObjectCreate,
   ObjectDefineProperties,
   ObjectDefineProperty,
+  Promise,
 } = primordials;
 
 const { fs: constants } = internalBinding('constants');

lib/internal/dns/promises.js

@@ -3,6 +3,7 @@
 const {
   ObjectCreate,
   ObjectDefineProperty,
+  Promise,
 } = primordials;
 
 const {

lib/internal/fs/rimraf.js

@@ -5,6 +5,11 @@
 // - Bring your own custom fs module is not currently supported.
 // - Some basic code cleanup.
 'use strict';
+
+const {
+  Promise,
+} = primordials;
+
 const {
   chmod,
   chmodSync,

lib/internal/http2/core.js

@@ -10,6 +10,7 @@ const {
   ObjectCreate,
   ObjectDefineProperty,
   ObjectPrototypeHasOwnProperty,
+  Promise,
   ReflectGetPrototypeOf,
   Symbol,
 } = primordials;

lib/internal/modules/esm/module_job.js

@@ -2,6 +2,7 @@
 
 const {
   ObjectSetPrototypeOf,
+  PromiseAll,
   SafeSet,
   SafePromise,
 } = primordials;
@@ -79,7 +80,7 @@ class ModuleJob {
       }
       jobsInGraph.add(moduleJob);
       const dependencyJobs = await moduleJob.linked;
-      return Promise.all(dependencyJobs.map(addJobsToDependencyGraph));
+      return PromiseAll(dependencyJobs.map(addJobsToDependencyGraph));
     };
     await addJobsToDependencyGraph(this);
     try {

lib/internal/per_context/primordials.js

@@ -47,6 +47,22 @@ function copyPropsRenamed(src, dest, prefix) {
   }
 }
 
+function copyPropsRenamedBound(src, dest, prefix) {
+  for (const key of Reflect.ownKeys(src)) {
+    if (typeof key === 'string') {
+      const desc = Reflect.getOwnPropertyDescriptor(src, key);
+      if (typeof desc.value === 'function') {
+        desc.value = desc.value.bind(src);
+      }
+      Reflect.defineProperty(
+        dest,
+        `${prefix}${key[0].toUpperCase()}${key.slice(1)}`,
+        desc
+      );
+    }
+  }
+}
+
 function copyPrototype(src, dest, prefix) {
   for (const key of Reflect.ownKeys(src)) {
     if (typeof key === 'string') {
@@ -135,5 +151,17 @@ primordials.SafePromise = makeSafe(
   copyPrototype(original.prototype, primordials, `${name}Prototype`);
 });
 
+// Create copies of intrinsic objects that require a valid `this` to call
+// static methods.
+// Refs: https://www.ecma-international.org/ecma-262/#sec-promise.all
+[
+  'Promise',
+].forEach((name) => {
+  const original = global[name];
+  primordials[name] = original;
+  copyPropsRenamedBound(original, primordials, name);
+  copyPrototype(original.prototype, primordials, `${name}Prototype`);
+});
+
 Object.setPrototypeOf(primordials, null);
 Object.freeze(primordials);

lib/internal/process/execution.js

@@ -2,6 +2,7 @@
 
 const {
   JSONStringify,
+  PromiseResolve,
 } = primordials;
 
 const path = require('path');
@@ -41,7 +42,7 @@ function evalModule(source, print) {
   const { log, error } = require('internal/console/global');
   const { decorateErrorStack } = require('internal/util');
   const asyncESM = require('internal/process/esm_loader');
-  Promise.resolve(asyncESM.ESMLoader).then(async (loader) => {
+  PromiseResolve(asyncESM.ESMLoader).then(async (loader) => {
     const { result } = await loader.eval(source);
     if (print) {
       log(result);

lib/internal/streams/async_iterator.js

@@ -4,6 +4,9 @@ const {
   ObjectCreate,
   ObjectGetPrototypeOf,
   ObjectSetPrototypeOf,
+  Promise,
+  PromiseReject,
+  PromiseResolve,
   Symbol,
 } = primordials;
 
@@ -67,11 +70,11 @@ const ReadableStreamAsyncIteratorPrototype = ObjectSetPrototypeOf({
     // reject straight away.
     const error = this[kError];
     if (error !== null) {
-      return Promise.reject(error);
+      return PromiseReject(error);
     }
 
     if (this[kEnded]) {
-      return Promise.resolve(createIterResult(undefined, true));
+      return PromiseResolve(createIterResult(undefined, true));
     }
 
     if (this[kStream].destroyed) {
@@ -103,7 +106,7 @@ const ReadableStreamAsyncIteratorPrototype = ObjectSetPrototypeOf({
       // without triggering the next() queue.
       const data = this[kStream].read();
       if (data !== null) {
-        return Promise.resolve(createIterResult(data, false));
+        return PromiseResolve(createIterResult(data, false));
       }
 
       promise = new Promise(this[kHandlePromise]);

lib/internal/util.js

@@ -10,6 +10,7 @@ const {
   ObjectGetOwnPropertyDescriptors,
   ObjectGetPrototypeOf,
   ObjectSetPrototypeOf,
+  Promise,
   ReflectConstruct,
   Symbol,
   SymbolFor,

lib/internal/worker.js

@@ -7,6 +7,8 @@ const {
   MathMax,
   ObjectCreate,
   ObjectEntries,
+  Promise,
+  PromiseResolve,
   Symbol,
   SymbolFor,
 } = primordials;
@@ -251,11 +253,11 @@ class Worker extends EventEmitter {
         'Passing a callback to worker.terminate() is deprecated. ' +
         'It returns a Promise instead.',
         'DeprecationWarning', 'DEP0132');
-      if (this[kHandle] === null) return Promise.resolve();
+      if (this[kHandle] === null) return PromiseResolve();
       this.once('exit', (exitCode) => callback(null, exitCode));
     }
 
-    if (this[kHandle] === null) return Promise.resolve();
+    if (this[kHandle] === null) return PromiseResolve();
 
     this[kHandle].stopThread();
 

lib/repl.js

@@ -55,6 +55,8 @@ const {
   ObjectKeys,
   ObjectPrototypeHasOwnProperty,
   ObjectSetPrototypeOf,
+  Promise,
+  PromiseRace,
   Symbol,
 } = primordials;
 
@@ -463,7 +465,7 @@ function REPLServer(prompt,
             };
             prioritizedSigintQueue.add(sigintListener);
           });
-          promise = Promise.race([promise, interrupt]);
+          promise = PromiseRace([promise, interrupt]);
         }
 
         promise.then((result) => {

lib/timers.js

@@ -23,6 +23,7 @@
 
 const {
   MathTrunc,
+  Promise,
 } = primordials;
 
 const {