Skip to content

Commit 312a4f3

Browse files
committed
net: fix bufferSize
bufferSize should only look at writableLength otherwise it will always show more than what is actually pending. PR-URL: #34088 Refs: #34078 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 8f4b4f2 commit 312a4f3

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/net.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ ObjectDefineProperty(Socket.prototype, 'readyState', {
541541
ObjectDefineProperty(Socket.prototype, 'bufferSize', {
542542
get: function() {
543543
if (this._handle) {
544-
return this[kLastWriteQueueSize] + this.writableLength;
544+
return this.writableLength;
545545
}
546546
}
547547
});

test/parallel/test-tls-buffersize.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ server.listen(0, common.mustCall(() => {
3131

3232
for (let i = 1; i < iter; i++) {
3333
client.write('a');
34-
assert.strictEqual(client.bufferSize, i + 1);
34+
assert.strictEqual(client.bufferSize, i);
3535
}
3636

3737
client.on('finish', common.mustCall(() => {

test/parallel/test-tls-streamwrap-buffersize.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const net = require('net');
5656

5757
for (let i = 1; i < iter; i++) {
5858
client.write('a');
59-
assert.strictEqual(client.bufferSize, i + 1);
59+
assert.strictEqual(client.bufferSize, i);
6060
}
6161

6262
client.on('end', common.mustCall());

0 commit comments

Comments
 (0)