Skip to content

Commit 31ec443

Browse files
mscdexMylesBorins
authored andcommitted
benchmark: remove problematic tls params
These very small values can cause crashes/exceptions to occur on some systems because most time is spent in V8 GC or in parts of node core that are not being tested (e.g. streams). PR-URL: #31816 Reviewed-By: James M Snell <[email protected]>
1 parent c0ba6ec commit 31ec443

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

benchmark/tls/secure-pair.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common.js');
33
const bench = common.createBenchmark(main, {
44
dur: [5],
55
securing: ['SecurePair', 'TLSSocket', 'clear'],
6-
size: [2, 100, 1024, 1024 * 1024]
6+
size: [100, 1024, 1024 * 1024]
77
});
88

99
const fixtures = require('../../test/common/fixtures');

benchmark/tls/throughput.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common.js');
33
const bench = common.createBenchmark(main, {
44
dur: [5],
55
type: ['buf', 'asc', 'utf'],
6-
size: [2, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024]
6+
size: [100, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024]
77
});
88

99
const fixtures = require('../../test/common/fixtures');

test/benchmark/test-benchmark-tls.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ runBenchmark('tls',
1919
'concurrency=1',
2020
'dur=0.1',
2121
'n=1',
22-
'size=2',
22+
'size=1024',
2323
'securing=SecurePair',
24-
'type=asc'
24+
'type=buf'
2525
],
2626
{
2727
NODEJS_BENCHMARK_ZERO_ALLOWED: 1,

0 commit comments

Comments
 (0)