Skip to content

Commit 320b80b

Browse files
danbevevanlucas
authored andcommitted
test: add --use-bundled-ca to tls-cnnic-whitelist
If configued with --openssl-use-def-ca-store --shared-openssl the following error might be thrown: assert.js:86 throw new assert.AssertionError({ ^ AssertionError: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE' === 'CERT_REVOKED' at TLSSocket.client.on.common.mustCall (/Users/danielbevenius/work/nodejs/node/test/parallel/test-tls-cnnic-whitelist.js:71:14) at TLSSocket.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitOne (events.js:115:13) at TLSSocket.emit (events.js:210:7) at emitErrorNT (net.js:1305:8) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9) In this case the CA's used will be the ones shipped with OpenSSL. For tests though we should be able to specify --use-bundled-ca as a fix for the above error, but this functionality was broken by me in commit be98f26 ("src: exclude node_root_certs when use-def-ca-store"). That commit removed the abilty to use --use-bundled-ca if the build was configured --openssl-use-def-ca-store. PR-URL: #12394 Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
1 parent 8ac387b commit 320b80b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/parallel/test-tls-cnnic-whitelist.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Flags: --use-bundled-ca
12
'use strict';
23
const common = require('../common');
34

0 commit comments

Comments
 (0)